Re: [PATCH] Added support for mdadm raid10 installs (#467996)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



A few things...

On Wednesday, February 18 2009, Martin Gracik said:
> diff --git a/loader2/loader.c b/loader2/loader.c
> index 0e7b88a..c9de64d 100644
> --- a/loader2/loader.c
> +++ b/loader2/loader.c
> @@ -1697,7 +1697,7 @@ int main(int argc, char ** argv) {
>      else if (FL_UPDATES(flags))
>          loadUpdates(&loaderData);
>  
> -    mlLoadModuleSet("md:raid0:raid1:raid5:raid6:raid456:dm-raid45:fat:msdos:jbd2:crc16:ext4dev:jbd:ext3:lock_nolock:gfs2:reiserfs:jfs:xfs:dm-mod:dm-zero:dm-mirror:dm-snapshot:dm-multipath:dm-round-robin:dm-emc:dm-crypt:dm-mem-cache:dm-region_hash:dm-message:aes_generic:sha256", modLoaded, modDeps, modInfo);
> +    mlLoadModuleSet("md:raid0:raid1:raid10:raid5:raid6:raid456:dm-raid45:fat:msdos:jbd2:crc16:ext4dev:jbd:ext3:lock_nolock:gfs2:reiserfs:jfs:xfs:dm-mod:dm-zero:dm-mirror:dm-snapshot:dm-multipath:dm-round-robin:dm-emc:dm-crypt:dm-mem-cache:dm-region_hash:dm-message:aes_generic:sha256", modLoaded, modDeps, modInfo);

Also should add the module to being loaded in liveinst/liveinst.sh.
It's probably worth a comment above this to that effect as well
  
> diff --git a/raid.py b/raid.py
> index cbe78a0..28829ed 100644
> --- a/raid.py
> +++ b/raid.py
> @@ -25,10 +25,12 @@ def getRaidLevels():
>          for l in f.readlines():
>              if not l.startswith("Personalities"):
>                  continue
> -            for tok in l.split():
> -                for lev in ("RAID0", "RAID1", "RAID5", "RAID6"):
> -                    if tok.upper().find(lev) != -1:
> -                        avail.append(lev)
> +
> +            lst = l.split()
> +
> +            for lev in ["RAID0", "RAID1", "RAID5", "RAID6", "RAID10"]:
> +                if "[" + lev + "]" in lst or "[" + lev.lower() + "]" in lst:
> +                    avail.append(lev)

Why the logic change here?  Also, we don't need to be able to runtime
modify the list + iterating over tuples is faster, so it's better to use
a tuple than a list here

Jeremy

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux