Re: PATCH: pyblock: stop calling get_group with non NULL terminated argv list

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This is a little different from what you sent me.  Is there a reason to
not just use {NULL}?  Moreover, I would like to see everything working
before commiting to anything.

regards.
On Mon, Feb 16, 2009 at 10:55:00PM +0100, Hans de Goede wrote:
> Hi All,
>
> Untested, but this should fix the dmraid errors and the hang we've been 
> seeing on nvidia
>
> Regards,
>
> Hans
>
> diff -up pyblock-0.34/dmraid.c~ pyblock-0.34/dmraid.c
> --- pyblock-0.34/dmraid.c~	2009-02-02 16:28:48.000000000 +0100
> +++ pyblock-0.34/dmraid.c	2009-02-16 22:52:56.000000000 +0100
> @@ -1269,18 +1269,11 @@ pydmraid_ctx_discover_raidsets(PyObject
>  		}
>
>  		Py_DECREF(name);
> -		if (!group_set(ctx->lc, &rd->name)) {
> -			/*
> -			 * This means that whatever was in name did not
> -			 * play well with current context.  lest try
> -			 * a NULL list.
> -			 */
> -			char *temp[] = {NULL};
> -			if (!group_set(ctx->lc, temp)){
> -				pyblock_PyErr_Format(GroupingError, "%s", rd->name);
> -				Py_DECREF(dict);
> -				return NULL;
> -			}
> +		char *argv[] = { rd->name, NULL };
> +		if (!group_set(ctx->lc, argv)) {
> +			pyblock_PyErr_Format(GroupingError, "%s", rd->name);
> +			Py_DECREF(dict);
> +			return NULL;
>  		}
>  		Py_DECREF(dict);
>  	}
>
> _______________________________________________
> Anaconda-devel-list mailing list
> Anaconda-devel-list@xxxxxxxxxx
> https://www.redhat.com/mailman/listinfo/anaconda-devel-list

-- 
Joel Andres Granados
Brno, Czech Republic, Red Hat.

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux