Re: [PATCH] Remove unused iface_netmask2prefix() function.

[Hans de Goede <hdegoede@xxxxxxxxxx>]

Hi,

All - lines I like!

Regards,

Hans


David Cantrell wrote:
> ---
>  isys/iface.c |   21 ---------------------
>  isys/iface.h |    5 -----
>  2 files changed, 0 insertions(+), 26 deletions(-)
>
> diff --git a/isys/iface.c b/isys/iface.c
> index eb3a20b..fd9459d 100644
> --- a/isys/iface.c
> +++ b/isys/iface.c
> @@ -297,27 +297,6 @@ struct in_addr *iface_prefix2netmask(int prefix) {
>  }
>  
>  /*
> - * Convert an IPv4 netmask to an IPv4 CIDR prefix.  Return -1 on failure.
> - */
> -int iface_netmask2prefix(struct in_addr *netmask) {
> -    int ret = -1;
> -    struct in_addr mask;
> -
> -    if (netmask == NULL) {
> -        return -1;
> -    }
> -
> -    memcpy(&mask, netmask, sizeof(struct in_addr));
> -
> -    while (mask.s_addr != 0) {
> -        mask.s_addr = mask.s_addr >> 1;
> -        ret++;
> -    }
> -
> -    return ret;
> -}
> -
> -/*
>   * Initialize a new iface_t structure to default values.
>   */
>  void iface_init_iface_t(iface_t *iface) {
> diff --git a/isys/iface.h b/isys/iface.h
> index ad10b64..59e3849 100644
> --- a/isys/iface.h
> +++ b/isys/iface.h
> @@ -125,11 +125,6 @@ char *iface_mac2str(char *);
>  struct in_addr *iface_prefix2netmask(int);
>  
>  /*
> - * Convert an IPv4 netmask to an IPv4 CIDR prefix.  Return -1 on failure.
> - */
> -int iface_netmask2prefix(struct in_addr *);
> -
> -/*
>   * Initialize a new iface_t structure to default values.
>   */
>  void iface_init_iface_t(iface_t *);

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list