Re: [PATCH 03/47] Remove partedUtils.get_partition_drive()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



David Cantrell wrote:
Chris Lumens wrote:
>From d754b55a984e7e311cbe49ee4d54df178d7bd61c Mon Sep 17 00:00:00 2001
From: David Cantrell <dcantrell@xxxxxxxxxx>
Date: Thu, 12 Feb 2009 09:00:28 -1000
Subject: [PATCH 03/47] Use os.path.basename in partedUtils.get_partition_drive()

Use os.path.basename rather than slicing the string.
---
 partedUtils.py |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/partedUtils.py b/partedUtils.py
index c170368..f7dab92 100644
--- a/partedUtils.py
+++ b/partedUtils.py
@@ -210,7 +210,7 @@ def set_partition_file_system_type(part, fstype):
def get_partition_drive(partition): """Return the device name for disk that PedPartition partition is on."""
-    return "%s" %(partition.geom.dev.path[5:])
+    return os.path.basename(partition.geom.dev.path)
def get_max_logical_partitions(disk):
     if not disk.type.check_feature(parted.DISK_TYPE_EXTENDED):

What happens when partition.geom.dev.path is /dev/cciss/wherever?

Oh piss, right, leave it to Compaq to make things not fun.


Taking get_partition_drive() to:

   return partition.geometry.device.path[5:]

--
David Cantrell <dcantrell@xxxxxxxxxx>
Red Hat / Honolulu, HI

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux