Re: [PATCH 01/47] Remove unused code in partedUtils.py

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



validateFsType() is still in use on line 1244 on partedUtils.py (in openDevices).

Joel Granados wrote:
From a quick view of partedUtils.py:

If we stop using fsTypes shouldn't the function partedUtils.py:validateFsType() be erased as well.  Sorry if this is taken care of in another patch :)

other than the previos observation, this seems good to me :)

----- "David Cantrell" <dcantrell@xxxxxxxxxx> wrote:

While going through partedUtils.py to see what can be pulled in
to the new pyparted, I found some things were no longer used by
anything in anaconda.  This patch removes that code.
---
 partedUtils.py |   19 +------------------
 1 files changed, 1 insertions(+), 18 deletions(-)

diff --git a/partedUtils.py b/partedUtils.py
index 2fc553c..abc5795 100644
--- a/partedUtils.py
+++ b/partedUtils.py
@@ -1,7 +1,7 @@
 #
 # partedUtils.py: helper functions for use with parted objects
 #
-# Copyright (C) 2002, 2003, 2004, 2005, 2006, 2007  Red Hat, Inc.
+# Copyright (C) 2002, 2003, 2004, 2005, 2006, 2007, 2008, 2009  Red
Hat, Inc.
 # All rights reserved.
 #
 # This program is free software; you can redistribute it and/or
modify
@@ -48,15 +48,6 @@ log = logging.getLogger("anaconda")
 import gettext
 _ = lambda x: gettext.ldgettext("anaconda", x)
-fsTypes = {}
-
-fs_type = parted.file_system_type_get_next ()
-while fs_type:
-    fsTypes[fs_type.name] = fs_type
-    fs_type = parted.file_system_type_get_next (fs_type)
-
-
-
 def get_flags (part):
     """Retrieve a list of strings representing the flags on the
partition."""
     string=""
@@ -249,11 +240,6 @@ def filter_partitions(disk, func):
return rc -def get_all_partitions(disk):
-    """Return a list of all PedPartition objects on disk."""
-    func = lambda part: part.is_active()
-    return filter_partitions(disk, func)
-
 def get_logical_partitions(disk):
     """Return a list of logical PedPartition objects on disk."""
     func = lambda part: (part.is_active()
@@ -1373,9 +1359,6 @@ class DiskSet:
return drives -# XXX is this all of the possibilities?
-dosPartitionTypes = [ 1, 6, 7, 11, 12, 14, 15 ]
-
 # master list of partition types
 allPartitionTypesDict = {
     0 : "Empty",
--
1.6.1.3

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list



--
David Cantrell <dcantrell@xxxxxxxxxx>
Red Hat / Honolulu, HI

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux