Re: [PATCH 03/47] Remove partedUtils.get_partition_drive()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jeremy Katz wrote:
On Wednesday, February 11 2009, David Cantrell said:
This function is just returns the device name without the /dev/
at the beginning.  No need for a function.

While technically there's no need for a function, using one keeps us
from scattering information on the exact object structure everywhere.
Which means that if it changes, there's less places to have to adapt
Yes, we're bad about it in other places but we should probably make a
concerted effort not to be making direct, deep accesses into objects as they
always seem to come back and bite us eventually :/

Not a problem, I'll just exclude this one when I merge.

Looking back at this particular patch, I think this was when I was going through partedUtils.py trying to get rid of unnecessary things and/or move things ot pyparted.

--
David Cantrell <dcantrell@xxxxxxxxxx>
Red Hat / Honolulu, HI

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux