[PATCH] Check that required kickstart commands are present early on (#483048).

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Text installs don't have all the steps anymore, so we meed to check that all
required information is given before proceeding.  Otherwise, a kickstart file
without a %packages section will traceback when anaconda attempts to show the
non-existant step.
---
 kickstart.py |   19 +++++++++++++++++++
 1 files changed, 19 insertions(+), 0 deletions(-)

diff --git a/kickstart.py b/kickstart.py
index eafd4d8..bf028f2 100644
--- a/kickstart.py
+++ b/kickstart.py
@@ -1259,3 +1259,22 @@ def setSteps(anaconda):
             dispatch.skipStep(n, permanent=1)
     for n in ksdata.showSteps:
         dispatch.skipStep(n, skip = 0)
+
+    # Text mode doesn't have all the steps that graphical mode does, so we
+    # can't stop and prompt for missing information.  Make sure we've got
+    # everything that would be provided by a missing section now and error
+    # out if we don't.
+    if ksdata.displaymode.displayMode == DISPLAY_MODE_TEXT:
+        missingSteps = [("bootloader", "Bootloader configuration"),
+                        ("group-selection", "Package selection")]
+        errors = []
+
+        for (step, msg) in missingSteps:
+            if not dispatch.stepInSkipList(step):
+                errors.append(msg)
+
+        if len(errors) > 0:
+            anaconda.intf.kickstartErrorWindow(_("Your kickstart file is missing "
+                "required information that anaconda cannot prompt for.  Please "
+                "add the following sections and try again:\n%s") % ", ".join(errors))
+            sys.exit(0)
-- 
1.6.0.3

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux