Re: PATCH: mkinitrd: FIX: nash unable to find dm devs by uuid or label (#480667)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hans de Goede wrote:


Peter Jones wrote:
@@ -393,12 +392,12 @@ nashBdevIterNext(nashBdevIter *iterp, struct nash_block_dev **dev)
                 continue;
             case POLLING:
                 timeout = iter->timeout;
- if (block_process_one_uevent(iter->nc, &timeout, &node) > 0
-                        && node) {
+ rc = block_process_one_uevent(iter->nc, &timeout, &node);
+                if (rc > 0 && node) {
                     *dev = node->bdev;
                     return 1;
                 }
-                if (speczero(&timeout))
+                if (rc <= 0)
                     iter->state = DONE;
                 continue;
             case DONE:

Ok, what have I missed here -- where are we handling a real timeout now?


A real timeout has a return status of 0, notice the:
                if (rc <= 0)
                     iter->state = DONE;


Check.

OK, this one's fine to commit then.

--
        Peter

Growth for the sake of growth is the ideology of the cancer cell.

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux