[PATCH] make ext4 default in UI (bug #481112)

[Radek Vykydal <rvykydal@xxxxxxxxxx>]

Hi,

this patch makes ext4 default in UI filesystem selection.
It also makes selecting /boot as mountpoint to automatically
select ext3 (in place of ext4) in filesystem combo.

---
autopart.py                    |    8 ++++----
fsset.py                       |    2 ++
iw/partition_ui_helpers_gui.py |    2 ++
3 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/autopart.py b/autopart.py
index 716fb12..f254c72 100644
--- a/autopart.py
+++ b/autopart.py
@@ -1712,20 +1712,20 @@ def getAutopartitionBoot(partitions):
                    and not req.mountpoint:
                req.mountpoint = "/boot/efi"
                ret = []
-        ret.append(("/boot", None, 200, None, 0, 1, 0))
+        ret.append(("/boot", "ext3", 200, None, 0, 1, 0))
        return ret
    elif (iutil.getPPCMachine() == "pSeries"):
        return [ (None, "PPC PReP Boot", 4, None, 0, 1, 0),
-                 ("/boot", None, 200, None, 0, 1, 0) ]
+                 ("/boot", "ext3", 200, None, 0, 1, 0) ]
    elif (iutil.getPPCMachine() == "iSeries") and not 
iutil.hasiSeriesNativeStorage():
        return [ (None, "PPC PReP Boot", 16, None, 0, 1, 0) ]
    elif (iutil.getPPCMachine() == "iSeries") and 
iutil.hasiSeriesNativeStorage():
        return []
    elif (iutil.getPPCMachine() == "PMac") and iutil.getPPCMacGen() == 
"NewWorld":
        return [ ( None, "Apple Bootstrap", 1, 1, 0, 1, 0),
-                 ("/boot", None, 200, None, 0, 1, 0) ]
+                 ("/boot", "ext3", 200, None, 0, 1, 0) ]
    else:
-        return [ ("/boot", None, 200, None, 0, 1, 0) ]
+        return [ ("/boot", "ext3", 200, None, 0, 1, 0) ]


# XXX hack but these are common strings to TUI and GUI
diff --git a/fsset.py b/fsset.py
index bb8b2a2..e00eebb 100644
--- a/fsset.py
+++ b/fsset.py
@@ -69,6 +69,8 @@ if iutil.isEfi():
fileSystemTypes = {}

def fileSystemTypeGetDefault():
+    if fileSystemTypeGet('ext4').isSupported():
+        return fileSystemTypeGet('ext4')
    if fileSystemTypeGet('ext3').isSupported():
        return fileSystemTypeGet('ext3')
    elif fileSystemTypeGet('ext2').isSupported():
diff --git a/iw/partition_ui_helpers_gui.py b/iw/partition_ui_helpers_gui.py
index e2ef4a7..3a1bc61 100644
--- a/iw/partition_ui_helpers_gui.py
+++ b/iw/partition_ui_helpers_gui.py
@@ -217,6 +217,8 @@ def createFSTypeMenu(fstype, fstypechangeCB, mountCombo,
def mountptchangeCB(widget, fstypecombo):
    if iutil.isEfi() and widget.get_children()[0].get_text() == 
"/boot/efi":
        fstypecombo.set_active_text("efi")
+    if widget.get_children()[0].get_text() == "/boot":
+        fstypecombo.set_active_text("ext3")

def resizeOptionCB(widget, resizesb):
    resizesb.set_sensitive(widget.get_active())
--
1.5.4.3

--- Begin Message ---

• Subject: [PATCH] make ext4 default in UI (bug #481112)
• From: Radek Vykydal <rvykydal@xxxxxxxxxx>
• Date: Thu, 22 Jan 2009 14:01:21 +0100
• User-agent: Thunderbird 2.0.0.18 (X11/20081119)

Hi,

this patch makes ext4 default in UI filesystem selection.
It also makes selecting /boot as mountpoint to automatically
select ext3 (in place of ext4) in filesystem combo.


---
autopart.py                    |    8 ++++----
fsset.py                       |    2 ++
iw/partition_ui_helpers_gui.py |    2 ++
3 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/autopart.py b/autopart.py
index 716fb12..f254c72 100644
--- a/autopart.py
+++ b/autopart.py
@@ -1712,20 +1712,20 @@ def getAutopartitionBoot(partitions):
                    and not req.mountpoint:
                req.mountpoint = "/boot/efi"
                ret = []
-        ret.append(("/boot", None, 200, None, 0, 1, 0))
+        ret.append(("/boot", "ext3", 200, None, 0, 1, 0))
        return ret
    elif (iutil.getPPCMachine() == "pSeries"):
        return [ (None, "PPC PReP Boot", 4, None, 0, 1, 0),
-                 ("/boot", None, 200, None, 0, 1, 0) ]
+                 ("/boot", "ext3", 200, None, 0, 1, 0) ]

elif (iutil.getPPCMachine() == "iSeries") and not iutil.hasiSeriesNativeStorage():

        return [ (None, "PPC PReP Boot", 16, None, 0, 1, 0) ]

elif (iutil.getPPCMachine() == "iSeries") and iutil.hasiSeriesNativeStorage():

        return []

elif (iutil.getPPCMachine() == "PMac") and iutil.getPPCMacGen() == "NewWorld":

        return [ ( None, "Apple Bootstrap", 1, 1, 0, 1, 0),
-                 ("/boot", None, 200, None, 0, 1, 0) ]
+                 ("/boot", "ext3", 200, None, 0, 1, 0) ]
    else:
-        return [ ("/boot", None, 200, None, 0, 1, 0) ]
+        return [ ("/boot", "ext3", 200, None, 0, 1, 0) ]


# XXX hack but these are common strings to TUI and GUI
diff --git a/fsset.py b/fsset.py
index bb8b2a2..e00eebb 100644
--- a/fsset.py
+++ b/fsset.py
@@ -69,6 +69,8 @@ if iutil.isEfi():
fileSystemTypes = {}

def fileSystemTypeGetDefault():
+    if fileSystemTypeGet('ext4').isSupported():
+        return fileSystemTypeGet('ext4')
    if fileSystemTypeGet('ext3').isSupported():
        return fileSystemTypeGet('ext3')
    elif fileSystemTypeGet('ext2').isSupported():
diff --git a/iw/partition_ui_helpers_gui.py b/iw/partition_ui_helpers_gui.py
index e2ef4a7..3a1bc61 100644
--- a/iw/partition_ui_helpers_gui.py
+++ b/iw/partition_ui_helpers_gui.py
@@ -217,6 +217,8 @@ def createFSTypeMenu(fstype, fstypechangeCB, mountCombo,
def mountptchangeCB(widget, fstypecombo):

if iutil.isEfi() and widget.get_children()[0].get_text() == "/boot/efi":

        fstypecombo.set_active_text("efi")
+    if widget.get_children()[0].get_text() == "/boot":
+        fstypecombo.set_active_text("ext3")

def resizeOptionCB(widget, resizesb):
    resizesb.set_sensitive(widget.get_active())
--
1.5.4.3

--- End Message ---

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list