Re: [PATCH] Call 'udevadm settle' instead of 'udevsettle'.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jesse Keating wrote:
> On Wed, 2008-12-17 at 17:38 -1000, David Cantrell wrote:
>> Log file had a message telling us to use 'udevadm settle' instead of
>> 'udevsettle' and that udevsettle support as argv[0] will be removed
>> in the future.  This patch changes loader to call 'udevadm settle'.
> 
> A little grepping finds udevsettle being called some more.
> 
> iscsi.py:            iutil.execWithRedirect("/sbin/udevsettle", [ ], 
> packages.py:                rc = iutil.execWithRedirect("udevsettle",
> [],
> 
> Those no longer work because we don't make the symlink anymore.

Also me.  I made the change in loader after I saw the warning message
from udevadm during boot up, but didn't check the Python code to see if
we call udevsettle.  Have a patch in the pipe for it too:

diff --git a/iscsi.py b/iscsi.py
index ec36b09..5feae15 100644
--- a/iscsi.py
+++ b/iscsi.py
@@ -194,7 +194,7 @@ class iscsiTarget:
             # It is possible when we get here the events for the new
devices
             # are not send yet, so sleep to make sure the events are fired
             time.sleep(1)
-            iutil.execWithRedirect("/sbin/udevsettle", [ ],
+            iutil.execWithRedirect("/sbin/udevadm", [ "settle" ],
                                    stdout = "/dev/tty5",
stderr="/dev/tty5")

         # we return True if there were any successful logins for our
portal.
diff --git a/packages.py b/packages.py
index cfc6ba2..7478c10 100644
--- a/packages.py
+++ b/packages.py
@@ -147,7 +147,7 @@ def turnOnFilesystems(anaconda):
                 # to settle
                 time.sleep(1)
                 w = anaconda.intf.waitWindow(_("Activating"),
_("Activating new partitions.
-                rc = iutil.execWithRedirect("udevsettle", [],
+                rc = iutil.execWithRedirect("/sbin/udevadm", [ "settle" ],
                                             stdout = "/dev/tty5",
                                             stderr = "/dev/tty5",
                                             searchPath = 1)

Testing now.

-- 
David Cantrell <dcantrell@xxxxxxxxxx>
Red Hat / Honolulu, HI

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux