David Cantrell wrote:
Hans de Goede wrote:
David Cantrell wrote:
This is a much more readable and reasonable patch to restore the
'ks' boot option functionality. The nextserver and bootfile are
read from the DHCP option set and used to build the URL to find
the kickstart file.
[rawhide]
---
loader/nfsinstall.c | 105
++++++++++++++++++++++++++++++++++++++------------
1 files changed, 80 insertions(+), 25 deletions(-)
diff --git a/loader/nfsinstall.c b/loader/nfsinstall.c
index 9a61cad..a098fe3 100644
--- a/loader/nfsinstall.c
+++ b/loader/nfsinstall.c
<snip>
@@ -476,8 +531,8 @@ int getFileFromNfs(char * url, char * dest, struct
loaderData_s * loaderData) {
failed = 1;
}
- free(host);
- free(path);
+ if (host) free(host);
+ if (path) free(path);
if (ip) free(ip);
umount("/tmp/mnt");
This chunck seems unrelated and is not needed, in C "if(x) free(x)" and
"free(x)" are 100% equivalent, as free ignores being called on NULL
pointers.
Yes, I know. We've had that discussion before. Old habits die hard, I
guess. Removed.
It looks fine otherwise, but I guess that was obvious from the lack of other
comments.
Regards,
Hans
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
