The patch does not conflict, it fits comfortably on top of what dcantrell commited. What I see in the code is that dcantrell makes sure that the DNS var is Ok. And then we go an put those strings into /etc/hosts. To me it looks ok. The only strange thing I saw was that the $DNS var before this patch was in between '""' and they are taken away for some reason. Don't think that this will be a problem since a dns address with a space inside is just wrong. But if it bothers people I can put it back in :) FYI, I'm looking at git diff 1263e881d7029c85bb0cca42abd5851827751d17, from the current tree. Regards. ----- "Hans de Goede" <hdegoede@xxxxxxxxxx> wrote: > David Cantrell wrote: > > Hans de Goede wrote: > >> > >> Joel Granados Moreno wrote: > >>> From: David Cantrell <dcantrell@xxxxxxxxxx> > >>> > >>> Write out nameserver lines in /etc/resolv.conf correctly and > >>> write out /etc/hosts containing localhost lines as well as a > >>> line for the host itself. This allows ssh X forwarding to work > >>> and telnetd to work.(459730) > >>> --- > >>> loader2/linuxrc.s390 | 9 ++++++++- > >>> 1 files changed, 8 insertions(+), 1 deletions(-) > >> Hmm, this seems to clash with the patch from dcantrell I've just > >> reviewed, please coordinate. > > > > The patch you reviewed for me was for rhel4-branch only. I should > have > > specified that. > > > > So is Joel's patch :) > > Regards, > > Hans > > _______________________________________________ > Anaconda-devel-list mailing list > Anaconda-devel-list@xxxxxxxxxx > https://www.redhat.com/mailman/listinfo/anaconda-devel-list -- Joel Andres Granados Red Hat / Brno Czech Republic _______________________________________________ Anaconda-devel-list mailing list Anaconda-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/anaconda-devel-list
