On Thu, Nov 06, 2008 at 05:29:47PM +0100, Hans de Goede wrote: > Hi All, > > iscsi.startup contains: > > for t in self.targets: > if not t.discover(): > continue > t.login() > > However all targets in the self.targets list are added through > iscsi.addTarget(), which does: > > t = iscsiTarget(ipaddr, port, user, pw, user_in, pw_in) > if not t.discover(): > return > if not t.login(): > return > self.targets.append(t) > > So we are already logged in to all the targets in self.targets, this relogin > attempts are harmless (other then making adding iscsi targets slower then > necessary), but do result in these messages on tty5: > iscsiadm: could not login to [.......]: > iscsiadm: initiator reported error (15 - already exists) > > Regards, > > Hans Minus signs are definitely what we like to see in anaconda patches. I like it. > >From 612fd44d186432a63a0dab18a128f29e19f42643 Mon Sep 17 00:00:00 2001 > From: Hans de Goede <hdegoede@xxxxxxxxxx> > Date: Thu, 6 Nov 2008 17:19:31 +0100 > Subject: [PATCH] iscsi.startup should not login to targets as we are already logged in (#470230) > > iscsi.startup contains: > > for t in self.targets: > if not t.discover(): > continue > t.login() > > However all targets in the self.targets list are added through > iscsi.addTarget(), which does: > > t = iscsiTarget(ipaddr, port, user, pw, user_in, pw_in) > if not t.discover(): > return > if not t.login(): > return > self.targets.append(t) > > So we are already logged in to all the targets in self.targets, this relogin > attempts are harmless (other then making adding iscsi targets slower then > necessary), but do result in these messages on tty5: > iscsiadm: could not login to [.......]: > iscsiadm: initiator reported error (15 - already exists) > --- > iscsi.py | 5 ----- > 1 files changed, 0 insertions(+), 5 deletions(-) > > diff --git a/iscsi.py b/iscsi.py > index f65e0db..51640b5 100644 > --- a/iscsi.py > +++ b/iscsi.py > @@ -459,11 +459,6 @@ class iscsi(object): > > self._startIscsiDaemon() > > - for t in self.targets: > - if not t.discover(): > - continue > - t.login() > - > if intf: > w.pop() > > -- > 1.6.0.3 > > _______________________________________________ > Anaconda-devel-list mailing list > Anaconda-devel-list@xxxxxxxxxx > https://www.redhat.com/mailman/listinfo/anaconda-devel-list -- David Cantrell <dcantrell@xxxxxxxxxx> Red Hat / Honolulu, HI
Attachment:
pgp81vubQ7S7A.pgp
Description: PGP signature
_______________________________________________ Anaconda-devel-list mailing list Anaconda-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/anaconda-devel-list
