Re: [PATCH] 469171 - calling newtWinMessage before startNewt

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2008-10-30 at 11:32 -0400, Chris Lumens wrote:
> > > Is there any reason we can't just call startNewt a lot earlier in main
> > > instead of playing the game of calling it as-needed a million other
> > > places?
> > 
> > The idea of lazily starting it is that we don't end up doing the blue
> > screen if we have everything we need to get to stage2 without any
> > dialogs, etc.  Then again, given our present flow, that's probably not a
> > likely case what with waiting for devices to settle, etc
> 
> Yeah true.  I just see a ton of places (especially in the networking
> code right now) where newtWinMessage can be called to display an error,
> but we are not guaranteed to ever have called startNewt.  This is the
> fun of the kickstart/cmdline vs. interactive flow all being mixed
> together.
> 
> I could alternatively go and add some more startNewt calls here and
> there.

Maybe we should have our own newtWinMessage that calls startNewt first.
But that's probably a post-F10 sort of thing.  So for F10, our best
choices are probably go through and try to add some startNewt() calls or
just do it early and deal with the blue screen people will get.  I don't
really have a strong leaning either way

Jeremy

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux