On Wed, Oct 29, 2008 at 04:37:54PM -0400, Chris Lumens wrote:
> Well here's an actually controversial patch for a change. NFSISO
> doesn't work with rawhide right now because nfsiso: is not a supported
> method string for the loader. Fixing the loader at this point in the
> cycle for this seems pretty risky to me, so instead I've got the
> following patch:
>
> diff --git a/yuminstall.py b/yuminstall.py
> index 3cf5f95..0e3b635 100644
> --- a/yuminstall.py
> +++ b/yuminstall.py
> @@ -421,6 +421,15 @@ class AnacondaYum(YumSorter):
> if not self.anaconda.intf.enableNetwork(self.anaconda):
> self._baseRepoURL = None
>
> + # This really should be fixed in loader instead but for now see
> + # if there's images and if so go with this being an NFSISO
> + # install instead.
> + images = findIsoImages("/mnt/isodir")
> + if images != {}:
> + self.anaconda.methodstr = "nfsiso:%s" % m[4:]
> + self.configBaseURL()
> + return
> +
> isys.mount(m[4:], self.tree, "nfs")
> elif m.startswith("cdrom:"):
> self._switchCD(1)
>
>
> The intention here is that if you've passed a method=nfs:, we check and
> see if there are ISO images in the directory. If so, then we treat it
> like NFSISO instead. If someone has both the exploded tree and the ISO
> images in the same directory, they're going to end up using the ISO
> images in this case. I don't think I care, because I can't imagine
> anyone wanting to do this. Thoughts?
I think this is fine, but should be mentioned in the release notes or some
other README-encoded documentation somewhere. Making this assumption to use
ISO images and changing it to nfsiso method later could leave some people
confused.
While I think it's unlikely, there is always the weird case where someone is
doing exactly what you think they won't do and it would be accompanied by a
long all caps explanation about why they do things that way (e.g., iso images
and exploded Fedora tree in the same directory).
--
David Cantrell <dcantrell@xxxxxxxxxx>
Red Hat / Honolulu, HI
Attachment:
pgpuzvkRgAHYz.pgp
Description: PGP signature
_______________________________________________ Anaconda-devel-list mailing list Anaconda-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/anaconda-devel-list
