On Wed, 2008-10-29 at 15:58 +0100, Hans de Goede wrote: > isys/isys.py:898: Function return types are inconsistent This (and others like it) are probably false positives to filter out > autopart.py:201: Using integer division (start / 1024) may return integer or float These also seem bogus > installclass.py:60: Methods (createbug, getbug, getbugs, getversion, login, > query) in AbstractFiler need to be overridden in a subclass And it is... installclass is also a base class > iscsi.py:319: string.atoi is deprecated These can be changed, but it probably shouldn't warn about deprecated things :) > iw/partition_ui_helpers_gui.py:51: Comparisons with True are not necessary and > may not work as expected Huh? > network.py:697: Using is not , may not always work I suspect it wants something like - while basename is not "" and basename[-1] in string.digits: + while basename != "" and basename[-1] in string.digits: which seems reasonable Jeremy _______________________________________________ Anaconda-devel-list mailing list Anaconda-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/anaconda-devel-list