Chris Lumens wrote:
These all look fine to go ahead and commit, with the exception of the couple comments below. I say go ahead and commit to master since they all look like relevant potential bugzilla entries to me.
Thanks for the review!
diff --git a/iw/GroupSelector.py b/iw/GroupSelector.py index 4a60d78..b56833a 100644 --- a/iw/GroupSelector.py +++ b/iw/GroupSelector.py @@ -97,7 +97,7 @@ def _deselectPackage(ayum, group, pkg): except mdErrors.PackageSackError: log = logging.getLogger("yum.verbose") log.debug("no such package %s from group %s" %(pkg, - self.group.groupid)) + group.groupid)) if pkgs: pkgs = ayum.bestPackagesFromList(pkgs) for po in pkgs:This can just be groupid, not group.groupid. See slightly above.
Erm, that should be grpid not groupid, but yes using that is better, fixed.
diff --git a/partedUtils.py b/partedUtils.py index 1ead010..de8eff4 100644 --- a/partedUtils.py +++ b/partedUtils.py @@ -1027,7 +1027,7 @@ class DiskSet: "-F", "-P", "-f", - "/dev/%s" % (dev,)] + "/dev/%s" % (drive,)]fd = os.open("/dev/null", os.O_RDWR | os.O_CREAT | os.O_APPEND)p = os.pipe()Can drive be "/dev/whatever" here, or is it just going to be "whatever"?
Note this is s390 only code, so I've looked at what RHEL-5.3 does as there we actually have testing on s390, and it seems that its always just "whatever". So I'm keeping this as is in the patch. In any case its better then the old reference a non existing variable code.
Applying now. Regards, Hans _______________________________________________ Anaconda-devel-list mailing list Anaconda-devel-list@xxxxxxxxxx https://www.redhat.com/mailman/listinfo/anaconda-devel-list
