On Jun 4, 2008, at 2:01 PM, Jeremy Katz wrote:
On Wed, 2008-06-04 at 13:40 -1000, David Cantrell wrote:
On Jun 4, 2008, at 3:11 AM, Jeremy Katz wrote:
On Tue, 2008-06-03 at 22:58 -1000, David Cantrell wrote:
Here's a patch to replace the rhpl.arch.canonArch stuff with the
same
thing from yum.rpmUtils. Not sure if we can use it the same way,
but
it didn't complain when I used it this way.
We should really avoid importing yum in iutil as that will cause
problems for other backends. Although we could arguably just move
the
functionality into yuminstall as that's really the only place it's
relevant
We also call it from anaconda, backend.py, and livecd.py. Not sure
where writeRpmPlatform() should live at this point.
Well, for one thing, the method is poorly named at this point. We
don't
actually *write* /etc/rpm/platform. Just /etc/rpm/macros. So the
need
from anaconda should be able to be handled by us just setting the
macros
ourselves via rpm.addMacro(). The call from livecd.py shouldn't be
needed as the live image should have things "right" already and if
not,
we should fix it. And the call from backend.py is probably due to
moving things around at one point
Actually as I think outloud... I'm halfway tempted to just rip the
method out entirely and file an rpm bug if things go badly
Sounds good to me. More minus signs!
--
David Cantrell <dcantrell@xxxxxxxxxx>
Red Hat / Honolulu, HI
_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list
