Re: [PATCH] removal of libdhcp

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



David Cantrell wrote:
On May 21, 2008, at 2:01 AM, John Summerfield wrote:

David Cantrell wrote:
No patch attached because it's quite large. I apologize for the length, but considering this replaces a library and introduces a new struct it meant a new file and changing calls everywhere.
   http://dcantrel.fedorapeople.org/anaconda/iface/
iface.h - Header file explaining the iface API. iface_t structure replacing pumpNetIntf and networkDeviceConfig, and all of the functions.
iface.patch - The changes, it's about 90% complete at this point.
*.txt - Explanations and notes.
This patch removes anaconda's use of libdhcp,

Why?
How will your patch improve Anaconda?[1]

libdhcp replaced libpump around F-5 or so. It's been nothing but

What was wrong with libpump?

trouble since then as it just wraps the client daemons and provides a sloppy control system around talking to them. And the dhcp clients don't even get executed correctly via this library anyway. It's been a real pain to keep working and it just needs to go.

So, the patch has us directly configuring interfaces using libnl (which is used by NM), and running the actual client daemons for dhcp and dhcpv6 when the user requests configuration that way. The same way it run on the target system.

How is/will Network Manager be better?

It's what the final system uses by default now and it's what we [the installer team/distribution] would like to ultimately use for network interface configuration during installation. If it's good enough for the final system, it should be good enough for the installer. So, it's more about using the same code for the same tasks.

Well, nm has (or should have, it was a bit limited when I last fought it) much more functionality than the installer's likely to need.


Does the result use less RAM?


Not necessarily.  But maybe.

Bear in mind that one of the major critcisms of Anaconda is its ever-expanding size. Folk were pretty unhappy with it arount RHL7 when some folk were trying to create an alternative, for smaller systems. Back then, I recall, one could install with 64 Mbytes of RAM.

More recently _I_ was pretty unhappy when it took over 12 hours to upgrade, in 256 Mbytes, from FC3 to FC5.

I favour a simple dhcp client that does an adequate job over a complex, over-featured alternative.




--

Cheers
John

-- spambait
1aaaaaaa@xxxxxxxxxxxxxxxx  Z1aaaaaaa@xxxxxxxxxxxxxxxx
-- Advice
http://webfoot.com/advice/email.top.php
http://www.catb.org/~esr/faqs/smart-questions.html
http://support.microsoft.com/kb/555375

You cannot reply off-list:-)

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux