Re: [patch] this is a pyparted patch for 429185

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2008-05-12 at 19:51 +0200, Joel Andres Granados wrote:
> The argument of waiting for pyparted to be rewritten is a considerable one.  If your 
> going to do the whole thing from scratch, why bother adding new stuff to the current 
> one.  OTOH, checking for the validity of the partition so in the anaconda code make 
> me feel dirty.  The other thing is that fix to anaconda goes in and then might stays 
> there even when the new pyparted is being used.  It might be good to do the anaconda 
> change and have a bug (if someone has a better idea of how to not let this fall 
> through the cracks please tell me) that documents this issue.

The anaconda change won't remain if we change the pyparted API.  There
are cases (including extendeds, iirc) where getting access to the
non-active partitions is important so you can't just go changing the
semantics of the API call.  If you control all the code up and down and
there aren't any "public" APIs exposed, then sure, you can change
semantics whenever -- but that's not the case here.

Jeremy

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux