Re: PATCH fix for 441556, 441546

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



clumens@xxxxxxxxxx wrote:
It sounds to me like in this case, loader is setting up /mnt/runtime or
wherever as the mount point for stage2, but later on systemMounted
thinks it's under /mnt/source and that's what's causing the error.
Agreed?

In that case we either need to make systemMounted smarter and know that
/mnt/runtime could be mounted, in which case it shouldn't do anything,
or we need to play with stuff in loader to move the stage2 image around.
I know which I prefer.

This is sort of what I was thinking, though this is completely untested:

diff --git a/yuminstall.py b/yuminstall.py
index a815e55..e62bc61 100644
--- a/yuminstall.py
+++ b/yuminstall.py
@@ -334,6 +334,11 @@ class AnacondaYum(YumSorter):
         if self._loopbackFile and os.path.exists(self._loopbackFile):
             return

+        # If we have the stage2 image mounted off the CD, don't do
+        # the rest of this stuff.
+        if os.path.ismount("/mnt/runtime"):
+            return
+
         stage2img = None

         if os.path.exists("/tmp/stage2.img"):


- Chris

Sorry for the delay...
Don't think that would work right, /mnt/runtime is always mounted at this point, even when stage2 lives in /tmp. Wouldn't accessing stage2 from the hard-drive of the newly installed system be faster that accessing from the cdrom, for accessing files on stage2?

I've been playing with having loader mount the boot.iso at /mnt/stage2 for all install types, and rescue works without any input, other than the boot prompt. I think I have stage1 worked out for url, hd, nfs, working on cd and nfsiso, interested?

Then, in yuminstall.py "if os.path.ismount("/mnt/stage2"):" or "if os.path.exists("/mnt/stage2/image/stage2.img"):" would be the only change needed.

Jerry




_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux