Re: [PATCH](resend)Fix gtk.MessageDialog Exception

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> anaconda sometimes calls anaconda.intf.messageWindow with
> exceptions.ValueError like this.
> But gtk.MessageDialog in messageWindow can not accept it.
> 
> so I added str() to gtk.MessageDialog like the attached patch.
> ----------------------
> self.dialog = gtk.MessageDialog(mainWindow, 0, style, buttons, str(text))
> ----------------------
> 
> or should I change all of calling side like the following?
> ----------------------
> self.intf.messageWindow(_("Error"), str(e))
> or
> self.intf.messageWindow(_("Error"), "%s" %(e,))
> ----------------------

I'd prefer to change the callers wherever possible, but since we keep
running into this problem I think it probably makes sense to fix it in
both places.  I'll apply the patch.

- Chris

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux