Re: [PATCH] Download and run Dogtail script

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Chris Lumens wrote:
+               # download completed, run the test
+               if not os.fork():
+                   # we are in the child
+                   os.chmod(testcase, 0755)
+                   os.execv(testcase, [testcase])
+                   sys.exit(0)
+               else:
+                   # we are in the parent, sleep to give time for the testcase to initialize
+                   # todo: is this needed, how to avoid possible race conditions
+                   time.sleep(1)

Probably cleaner here to os.waitpid() instead of sleeping, but it looks
fine otherwise.

We will probably also want to add a dogtail command to kickstart which
is very easy to do.

I can't recall the exact reasoning ... but there was some debate about whether we'd use kickstart or dogtail or both and where was best to add dogtail support. For the time being I'm content to simply provide the environment to support the user in running dogtail cmds from %pre or via cmdline (manual install).

However, if that avenue is worth pursuing there are pykickstart patches posted at https://www.redhat.com/archives/anaconda-devel-list/2007-April/msg00045.html

Thanks,
James

--
==========================================
 James Laska         -- jlaska@xxxxxxxxxx
 Quality Engineering -- Red Hat, Inc.
==========================================

_______________________________________________
Anaconda-devel-list mailing list
Anaconda-devel-list@xxxxxxxxxx
https://www.redhat.com/mailman/listinfo/anaconda-devel-list

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux