Jeremy Katz (katzj@xxxxxxxxxx) said: > In general, doesn't seem like a wrong thing to do, but .... > > On Fri, 2007-09-14 at 23:29 -0400, Bill Nottingham wrote: > > The attached: > > > > 1) cleans up/simplifies readImageFromFile, removing options no longer used > > Looks okay. Need to make sure that the splash image still looks okay > with this at a lower res (like a livecd install running the desktop at > 800x600), but I think it should be okay. lowres isn't functioning in anaconda ATM, so this was hard to test. > > 3) uses readIconFromTheme, where available, using XDG standard names > > Some of the icons being used are ... a bit arbitrary as "this matches > what the image was" rather than "this is the intent of the icon naming > theme. eg, using applications-internet for the timezone screen just > happens to work given our icon theme, but can't really be guaranteed at > all. If there's not something which matches the intent, we probably > shouldn't go with it to avoid more problems down the road. Right; it's a matter of either 1) using xdg-approved names 2) picking something else that happens to be in the icon theme, and hoping it stays there. Six of one, half dozen of the other. Bill
