I mentioned on fedora-devel that I might try to put together (today) a patch to
fix 250301. I said this because I know jkatz is out for the week, and it seems
like this would be a _really_ nice thing to fix for f8t1.
However, even though I have been posting anaconda patches of late, I am hardly a
seasoned python&anaconda hacker, able to instantaneously fix things like this.
Basically I can feel myself falling into that cliche of only having the
motivation to work on the features that I'm having fun with, and not the bugs
that are more important to the wider community.
So in case that happens. Here is what I would consider the bare minimal patch
that ought to be applied for F8T1. From what I can gather so far, the next
better patch would be to replicate queryNoFormatPreExisting as something like
liveInstMustFormatRoot, and invoke it appropriately in the 4 places where the
query one is invoked. The next better beyond that would be to implement a file
level copy installation mechanism so that it actually is possible to leave '/'
unformatted. Or find a way to disallow the option of not formatting in the UI.
And quite probably Jeremy or other more seasoned anaconda people might know of
better solutions than those.
-dmc
diff -Naur anaconda.cvs.20070716/partIntfHelpers.py anaconda/partIntfHelpers.py
--- anaconda.cvs.20070716/partIntfHelpers.py 2007-07-06 14:53:27.000000000 -0500
+++ anaconda/partIntfHelpers.py 2007-07-31 16:04:07.000000000 -0500
@@ -414,7 +414,10 @@
"do not cause problems with this installation of Linux. "
"However, if this partition contains files that you need "
"to keep, such as home directories, then "
- "continue without formatting this partition.")
+ "continue without formatting this partition."
+ ""
+ "FEDORA 8 TEST1 WARNING: If installing from LiveCD/LiveUSB,"
+ "the root '/' filesystem will be formatted NO MATTER WHAT!!!")
rc = intf.messageWindow(_("Format?"), txt, type = "custom", custom_buttons=[_("_Modify Partition"), _("Do _Not Format")], custom_icon="warning")
return rc
