On Fri, 22 Jun 2007 23:21:08 +0900 HARA Hiroshi <hhara@xxxxxxxxxxxxxxxx> wrote: > After I sent you the netconfig_dialog.py.diff yesterday, > I think that it is better that anaconda supports > CIDR prefix at Add iSCSI target setup. > (I'm sorry for bothering you.) > > Would you review my additional patch, please ? There's been a lot of outside work on this area of anaconda lately, which is great. I just committed some other changes to the netconfig_dialog.py file earlier. Regarding your patch... I made the following changes when applying it: 1) Changed Netmask to 'IPv4 Network Mask' in dialog box titles. 2) When you use prefix2netmask to convert the prefix to a netmask, you forget to set it in netdev (and sanity check it), so I added that. Other than that, looks good. Thanks! -- David Cantrell <dcantrell@xxxxxxxxxx> Red Hat / Westford, MA
Attachment:
pgpcLbWXb7CPF.pgp
Description: PGP signature
