On Wed, 2007-02-21 at 09:59 -0500, Chris Lumens wrote:
> > Okay - it's been changed to be non-interactive, and instead just emits
> > warning messages if you don't set flags.
>
> Thanks. I rebuilt anaconda with this yesterday afternoon, as you may
> have seen me talk about in irc. I also grabbed your other patch that
> was a followup to this one.
Awesome. There was a thinko in the first part of the patch, though:
Index: maketreeinfo.py
===================================================================
RCS file: /usr/local/CVS/anaconda/scripts/maketreeinfo.py,v
retrieving revision 1.1
diff -u -r1.1 maketreeinfo.py
--- maketreeinfo.py 20 Feb 2007 22:52:43 -0000 1.1
+++ maketreeinfo.py 21 Feb 2007 23:00:42 -0000
@@ -63,7 +63,7 @@
if data["variant"] is None:
print >> sys.stderr, "--variant missing, but that's OK."
- data["version"] = ""
+ data["variant"] = ""
if data["version"] is None:
print >> sys.stderr, "--version missing! This is probably bad!"
D'oh. Hope that helps. This patch should mean really cool things for
automated installer testing. Thanks for applying it.
-w
Attachment:
signature.asc
Description: This is a digitally signed message part
