Re: anaconda bug: loader2/cdinstall.c's use of probeDevices

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Steven Augart (saugart@xxxxxxxxxxxxxxxx) said: 
> at this early stage in installation.  As matters stand, I don't get a
> shell until Python/Anaconda is running, after Kudzu has been weird, and
> I will explain why I think USB is ok at that point (at least):

Right, the shell doesn't start until the second stage installer. Actually,
if you get to that point on a CD install, then the CD *is* working...

So, looking at the code briefly, I suspect that kickstartfromCD
needs to iterate over the devices (and check for NULL.) Or not probe
the USB bus.  (in kudzu parlance, USB CDs are SCSI.)

Try the *completely untested* patch attached. It may need some fudging.

Bill
Index: cdinstall.c
===================================================================
RCS file: /usr/local/CVS/anaconda/loader2/cdinstall.c,v
retrieving revision 1.39
diff -u -r1.39 cdinstall.c
--- cdinstall.c	1 Dec 2005 16:51:04 -0000	1.39
+++ cdinstall.c	10 May 2006 02:18:32 -0000
@@ -444,14 +444,15 @@
     if (!p || strlen(kspath) < 1)
 	kspath = "/ks.cfg";
 
-    if ((rc=getKickstartFromBlockDevice(devices[0]->device, kspath))) {
-	if (rc == 3) {
-	    startNewt(flags);
-	    newtWinMessage(_("Error"), _("OK"),
-			   _("Cannot find kickstart file on CDROM."));
-	}
-	return 1;
+    for (i=0; devices[i]; i++) {
+	if (!devices[i]->device) continue;
+		 
+	rc = getKickstartFromBlockDevice(devices[0]->device, kspath);
+	if (rc == 0)
+	    return 0;
     }
-
-    return 0;
+    startNewt(flags);
+    newtWinMessage(_("Error"), _("OK"),
+		   _("Cannot find kickstart file on CDROM."));
+    return 1;
 }

[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux