On Tue, 2006-02-07 at 16:18 -0800, Patrick Mansfield wrote: > I've made changes that should address all of your comments. Great. > Patched again against anaconda-10.91.12, and again tested with FC devel > snapshot of Jan 2. > > Besides addressing your previous comments, changes from last posting are: [snip] > The text and gui already display the default port value - I don't think > that was clarified. This all looks good now. I made a slight change so that the execWithRedirect calls actually send their output somewhere. But with that done, I've committed it to CVS. > It still does not have: > > - support for copying of iSCSI config files needed by initrd (or even > normal iSCSI startup), like /etc/initiatorname.iscsi or whatever else is > needed for initrd support Yep, exactly what is needed here is still TBD. But it should be easy enough to add once we know. > - support iSCSI kickstart > - auto-select the iscsi-initiator-tools for installation (not sure how or > if this is possible) For right now, the way to do this is probably just to make them installed by default. We probably need something more general here for ensuring dmraid, lvm, etc all get installed. Thanks for the patches! Jeremy
