Re: [PATCH 05/05] add iscsi guy install

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2006-02-03 at 14:05 -0800, Patrick Mansfield wrote:
> Add the iscsi_gui.py install module, and the call to it. 

Looks fine.

> Add iscsi glade file.

This could use a little bit of HIG love.  Main suggestions for
improvement would be
* Bold the labels
* Use a : before the entries
* The table shouldn't need to be in an alignment
* Instead of putting the default in braces for the port, just set the
default port in the entry box 
* Consistency in capitalization of the labels

Jeremy


[Index of Archives]     [Kickstart]     [Fedora Users]     [Fedora Legacy List]     [Fedora Maintainers]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]
  Powered by Linux