On Mon, 2005-10-03 at 14:57 -0400, Brian Long wrote: > On Mon, 2005-10-03 at 13:04 -0400, Jeremy Katz wrote: > > On Mon, 2005-10-03 at 13:02 -0400, Brian Long wrote: > > > On Mon, 2005-10-03 at 12:00 -0400, Jeremy Katz wrote: > > > > On Thu, 2005-09-15 at 17:53 -0400, Jeremy Katz wrote: > > > > > On Thu, 2005-09-15 at 11:50 -0400, Brian Long wrote: > > > > > > The patch in the following Bugzilla adds nfsmountopts flag to Anaconda. > > > > > > This is parsed by loader and used in the doPwMount function when the NFS > > > > > > client mounts /mnt/source. > > > > > > > > > > > > This is needed to override the kickstart kernel defaults in RHEL 4 of > > > > > > rsize=32768,wsize=32768,udp. If tcp was being used, the large > > > > > > rsize,wsize would not be a problem. With udp, however, large > > > > > > rsize,wsize is causing longer installation times due to retransmissions. > > > > [snip] > > > > > For the other side of things, I'd rather see the nfs options in the > > > > > 'nfs' kickstart directive and with special handling in ks=nfs:... rather > > > > > than making another bit of global data. Although this doesn't help the > > > > > interactive case right now, we'll probably going to have to do something > > > > > for when we add NFSv4 support anyway, so this is a logical step to move > > > > > things in the right direction. > > > > > > > > Had a chance to look at doing this part of things? > > > > > > No, I have not checked out CVS head to see your changes. Did you expect > > > me to provide a patch as well? The last email I read said you committed > > > something to CVS head to change doPwMount. > > > > All I did was the changes to make passing options into doPwMount more > > reasonable, none of the handling to actually get nfs options handled > > without just overloading a hack into loaderData with command line > > options. > One question. You mention ks=nfs: and nfs kickstart directive (inside > ks.cfg). What about the use case where ks=http: but the ks.cfg contains > the nfs directive? Are you saying only the kickstart directive in > ks.cfg would have the NFS mount options? Or the mount options would be > able to be specified either in ks=nfs: or nfs kickstart directive? I'd make them both be specified and not connected -- it definitely feels like the sort of thing that you want to be able to handle on a per-mount basis. Jeremy
