> -----Original Message----- > From: Jeremy Katz [mailto:katzj@xxxxxxxxxx] > Sent: Tuesday, June 29, 2004 3:11 PM > To: Kabir, Rezwanul > Cc: Domsch, Matt; anaconda-devel-list@xxxxxxxxxx > Subject: RE: EDD disksigs for disks other than 0x80 > > > > diff -urNp old-anaconda-10/loader2/eddsupport.c > > anaconda-10.0/loader2/eddsupport.c > > --- old-anaconda-10/loader2/eddsupport.c 1969-12-31 > > 18:00:00.000000000 -0600 > > +++ anaconda-10.0/loader2/eddsupport.c 2004-06-29 > 11:24:47.632167320 > > -0600 > > @@ -0,0 +1,464 @@ > > +/* This is the top level function that creates the disk > list present in > > the > > + system, checks to see if unique signatures exist on the disks at > > offset 0x1b8. > > + If unique signature exists then it will find out the BIOS disk80 > > device by > > + reading in the MBR sig and compare it against the > signatures on the > > disks and > > + set the environment variable DISK80 to whatever the hd/sd > name it has. > > If > > + unique signatures don't exist on the disks, then it will > write unique > > + signatures on the disks and reboot */ > > Unfortunately, this is a bit of a non-starter for real inclusion. > Random reboots aren't at all guaranteed to get back into the > installation environment. There's actually a pretty good chance that > they won't. So, I think that instead, the proper course is if a bios > disk is specified that we can't determine, we just have to > pop up a nice > error dialog. > > anaconda can't get into the business of being responsible for your > machine being set up properly to begin with (although it's conceivable > to add some stuff to make it easier to add unique sigs if > you're in the > case where you don't have them; that shouldn't be the default behavior > though) I understand your concerns here. The above actually works better in a more controlled environment.Okay, I'll remove the part where it tries to write signatures and reboot... --rez
