On Fri, 2004-06-25 at 14:53 -0500, Rezwanul_Kabir@xxxxxxxx wrote: > One of the reasons ,I used environment variables is to access them in > consistent manner between loader and anaconda. Otherwise I would have to > touch more codes to pass them to anaconda in some way, e.g. as command > line arguments.. There shouldn't be a need to pass information around, though. Whether or not edd is being used should be pretty obvious based on whether or not they ask for something in terms of BIOS disks. > >2) Doing replacements of things inside the kickstart config is going > to be fragile. I'd > >really prefer to avoid that. Two possible approaches for doing so > would be [snip] > My idea here was to decouple the "EDD" stuff as much as possible from > the rest of the code.This would allow > development/modification/experimentation with "EDD" code independently > from the rest of the bulk. With this in mind, to parse boot options or > ks.cfg, I introduced some hooks into the loader/anaconda code > (parseEDDHDCommand,EDDfy etc.)that would behave as wrapper/adapter. They > allow "current" options to pass through without any scrutiny and will > convert any new "EDD options" into their corresponding "current" > format.The back end, which makes sense of this options remains the > same... Unfortunately, although this makes sense for making the devel work easier at first, it makes it far harder to maintain in the long-term. And following one of my ideas for a whole new way to refer to them makes it easy to tell whether or not anything new got used. Wrappers are horrible to track through when you start getting bugs :( > >Why have the noedd flag -- edd will only get utilized if people request > it, especially if > >we're not rewriting the ks.cfg. Does loading the module cause an oops > in some cases? > > I used it basically to do two things 1) load the edd.o module 2) > activate hooks in loader/anaconda that deals with EDD specific options.. If loading the module doesn't cause problems, then it can always be loaded. And if you're not using wrappers and instead have things which explicitly mean that EDD is getting use, then you don't need to activate hooks. Jeremy
