On Tue, Jun 26, 2012 at 14:24:03, Mark Brown wrote: > On Tue, Jun 26, 2012 at 11:33:43AM +0530, Hebbar, Gururaja wrote: > > In sound/soc/codecs/tlv320aic3x.c > > > > data = snd_soc_read(codec, AIC3X_PLL_PROGA_REG); > > snd_soc_write(codec, AIC3X_PLL_PROGA_REG, > > data | (pll_p << PLLP_SHIFT)); > > > > In the above code, pll-p value is OR'ed with previous value without > > clearing it. Bug is not seen if pll-p value doesn't change across > > Sampling frequency. > > A better fix is to change the code to use snd_soc_update_bits() rather > than open code it. This is more idiomatic and will suppress writes if > they don't change anything. > Sure will resend the patch. Thanks for the review Regards, Gururaja ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Alsa-user mailing list Alsa-user@xxxxxxxxxxxxxxxxxxxxx https://lists.sourceforge.net/lists/listinfo/alsa-user
