Re: Midi issue with 1.0.12 and ice1712

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



At Thu, 26 Oct 2006 09:18:13 +0200,
Clemens Ladisch wrote:
> 
> Bob van der Poel wrote:
> > I've just installed Mandriva 2007. It is using alsa 1.0.12 with my 
> > audiophile 2496 card. Oh, this is on linux  kernel 2.6.17-5mdv.
> > 
> > There appears to be a problem with midi output. A few times now my 
> > entire computer has locked while playing a midi file using aplaymidi.
> 
> This looks like the RTC bug.

Yes, there is a known ABBA deadlock between rtc and snd-timer.
At least, we need to remove a spinlock in rtc.c.  The patch below
should fix, but it seems not enough to clean up all problems.
Unfortunately, I've had little time to investigate it yet.


Takashi

diff --git a/drivers/char/rtc.c b/drivers/char/rtc.c
index ab6429b..46d2896 100644
--- a/drivers/char/rtc.c
+++ b/drivers/char/rtc.c
@@ -869,15 +869,10 @@ int rtc_control(rtc_task_t *task, unsign
 #ifndef RTC_IRQ
 	return -EIO;
 #else
-	unsigned long flags;
 	if (cmd != RTC_PIE_ON && cmd != RTC_PIE_OFF && cmd != RTC_IRQP_SET)
 		return -EINVAL;
-	spin_lock_irqsave(&rtc_task_lock, flags);
-	if (rtc_callback != task) {
-		spin_unlock_irqrestore(&rtc_task_lock, flags);
+	if (rtc_callback != task)
 		return -ENXIO;
-	}
-	spin_unlock_irqrestore(&rtc_task_lock, flags);
 	return rtc_do_ioctl(cmd, arg, 1);
 #endif
 }

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Alsa-user mailing list
Alsa-user@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/alsa-user

[Index of Archives]     [ALSA Devel]     [Linux Audio Users]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [Yosemite Photos]     [KDE Users]     [Fedora Tools]

  Powered by Linux